Singu hides ball on disarm, also hides halo effect#5768
Open
SteelBlueZK wants to merge 5 commits into
Open
Conversation
Contributor
Author
Member
|
I liked how the halo remained because it showed that there is some latent energy there (it still explodes big, etc). The boolean disappearing is a bit jarring, perhaps LUPS should receive support for particles where the rules param is a scaling factor? Disarm part looks good. |
SteelBlueZK
force-pushed
the
singudisarm
branch
2 times, most recently
from
eb73ed2 to
84c69c8
Compare
Due to the new scaling of static particle, the effect already disapears before the ball disappears. No reason to have this rule param turning it off.
Contributor
Author
|
lups class change btw: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5767
Needs review,
Adds arbitrary unit rules command to energysingu "ballShow" to control halo
spams a Spring.SetUnitRulesParam for about 17 consecutive frames when shrinking ball cause of emp/disarm
arbitrary numbers controling when halo turns on/off
visual: https://discord.com/channels/278805140708786177/278908415756206080/1520667932257161297