Fix lint offenses and enforce lint in CI - #300
Merged
Merged
Conversation
…dRubyVersion, tune Metrics)
- Rename internal builder/parser parameters to descriptive names - Add targeted rubocop:disable comments for public API names kept for backward compatibility (builders, accessors, constants) - Convert private read_unread_restriction to keyword argument - Wrap long lines; use meaningful heredoc delimiters - Remove continue-on-error from the lint CI job so RuboCop is required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up all RuboCop offenses across the codebase and makes the lint CI job required.
frozen_string_literalmagic comments; fixes the one real mutation hazardrubocop:disablecomments for backward compatibilityGemspec/RequiredRubyVersiondisabled with an explanatory comment: gemspec floors stay intentionally lowcontinue-on-errorfrom the lint job so RuboCop failures now fail CITests:
bundle exec rspec— 59 examples, 0 failures.bundle exec rubocop— 0 offenses (was 4,622).