Skip to content

Fix datetime day filtering#767

Draft
driavysinus wants to merge 2 commits into
VectorInstitute:mainfrom
driavysinus:fix/filter-datetime-day-component
Draft

Fix datetime day filtering#767
driavysinus wants to merge 2 commits into
VectorInstitute:mainfrom
driavysinus:fix/filter-datetime-day-component

Conversation

@driavysinus

@driavysinus driavysinus commented Jul 8, 2026

Copy link
Copy Markdown

Problem

filter_datetime(..., day=...) currently reads the year component when applying the day filter, so day-of-month slicing can incorrectly return no matches.

Fix

Use pc.day(...) for the day branch and add a focused unit test for day-of-month filtering.

Validation

Z:\uv\uv.exe run --with datasets==2.21.0 --with pytest --with pandas --with pyarrow --with numpy --with psutil python -m pytest tests\cyclops\data\test_slicer_datetime.py -q
python -m py_compile cyclops\data\slicer.py tests\cyclops\data\test_slicer_datetime.py

Note: I used datasets==2.21.0 locally to match the repository's Poetry constraint range and avoid newer datasets API drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant