Feat/nickforce - #97
Open
MrIron-no wants to merge 3 commits into
Open
Conversation
…to iauth auth_set_account() now splits account[:id[:flags[:...]]] from an optional umode-like second word (+x / +xo), ignores future colon fields and trailing tokens for local state, and sends the original string to iauth as "A ...". Tests cover the variants against a logging iauth stub. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the client's chosen nick fixed until registration completes so iauth sees a stable nickname and can reliably override it with "f". A failed forced nick now sets AR_IAUTH_NEEDS_NICK, which blocks registration (even after Done) until iauth supplies a subsequent valid "f"; successful assignment notifies the client with NICK before the local rename. Document the E Missing/Invalid/InUse retry contract, and expand the iauth_nick harness: force testnick to Guest001 before Done across SASL OK, SASL FAIL, and no-SASL paths; keep non-forced nicks unchanged; reject mid-auth NICK changes; and exercise invalid/in-use force retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.