Skip to content

feat[oz-retainer-07]: emit bond and liveness update events - #58

Open
md0x wants to merge 1 commit into
pablo/fro-106-reward-cancellationfrom
pablo/oz-retainer-07-bond-liveness-events
Open

feat[oz-retainer-07]: emit bond and liveness update events#58
md0x wants to merge 1 commit into
pablo/fro-106-reward-cancellationfrom
pablo/oz-retainer-07-bond-liveness-events

Conversation

@md0x

@md0x md0x commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Audit remediation feature

Managed OO requester-set bond and custom liveness changes currently mutate request settings without oracle-side events. This additional Retainer 07 feature makes those changes observable while preserving the request-manager override behavior.

This PR is built on #56, which provides the event pattern and optimizer setting required for the available EIP-170 margin.

References: FRO-109 · audited scope tag

Resolution

  • Add BondUpdated and CustomLivenessUpdated with the concrete request tuple and old/new values.
  • Emit each event after the requester-controlled setting is updated.
  • Cover initial defaults, subsequent updates, lifecycle restrictions, and request-manager override precedence.
  • Document how consumers combine requester events with request-manager override events to derive effective proposal settings.

Validation

  • forge test --match-contract 'ManagedOptimisticOracleV2Test|DeferredPayoutTest' — 74 tests passed
  • Polygon fork suites — 15 tests passed
  • cd pm-v2-oo-reporter && forge test --match-path test/OOReporter.t.sol — 45 tests passed
  • forge build --sizesManagedOptimisticOracleV2 24,469 B (107 B margin)
  • cd pm-v2-oo-reporter && forge fmt --check
  • git diff --check

@linear

linear Bot commented Jul 30, 2026

Copy link
Copy Markdown

FRO-109

@md0x
md0x marked this pull request as ready for review July 30, 2026 09:42
@md0x
md0x changed the base branch from unaudited-pm-v2-oo-reporter to pablo/fro-106-reward-cancellation July 30, 2026 09:48
@md0x
md0x requested review from Reinis-FRP and chrismaree July 30, 2026 10:41

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed FRO-109 at this exact head. The new events, emission timing, initial/subsequent values, lifecycle restrictions, request-manager precedence, ABI compatibility, coverage, and consumer documentation are correct.

This approval is for #58’s intrinsic diff. Do not merge it while parent PR #56 has requested changes; once #56 is accepted, rebase/retarget #58 and revalidate the final contract sizes because the reported Managed OO margin is only 107 bytes.


Sent from Chris Codex Agent 🤖

@Reinis-FRP Reinis-FRP left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, we indeed should have added these when porting to this repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants