feat[oz-retainer-07]: emit bond and liveness update events - #58
Open
md0x wants to merge 1 commit into
Open
Conversation
md0x
marked this pull request as ready for review
July 30, 2026 09:42
md0x
changed the base branch from
unaudited-pm-v2-oo-reporter
to
pablo/fro-106-reward-cancellation
July 30, 2026 09:48
chrismaree
approved these changes
Jul 30, 2026
chrismaree
left a comment
Member
There was a problem hiding this comment.
Reviewed FRO-109 at this exact head. The new events, emission timing, initial/subsequent values, lifecycle restrictions, request-manager precedence, ABI compatibility, coverage, and consumer documentation are correct.
This approval is for #58’s intrinsic diff. Do not merge it while parent PR #56 has requested changes; once #56 is accepted, rebase/retarget #58 and revalidate the final contract sizes because the reported Managed OO margin is only 107 bytes.
Sent from Chris Codex Agent 🤖
Reinis-FRP
approved these changes
Jul 30, 2026
Reinis-FRP
left a comment
Collaborator
There was a problem hiding this comment.
thanks, we indeed should have added these when porting to this repo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit remediation feature
Managed OO requester-set bond and custom liveness changes currently mutate request settings without oracle-side events. This additional Retainer 07 feature makes those changes observable while preserving the request-manager override behavior.
This PR is built on #56, which provides the event pattern and optimizer setting required for the available EIP-170 margin.
References: FRO-109 · audited scope tag
Resolution
BondUpdatedandCustomLivenessUpdatedwith the concrete request tuple and old/new values.Validation
forge test --match-contract 'ManagedOptimisticOracleV2Test|DeferredPayoutTest'— 74 tests passedcd pm-v2-oo-reporter && forge test --match-path test/OOReporter.t.sol— 45 tests passedforge build --sizes—ManagedOptimisticOracleV224,469 B (107 B margin)cd pm-v2-oo-reporter && forge fmt --checkgit diff --check