test(snapshot): cover the placeholder matcher and normalization internals#822
Merged
Conversation
…nals assert_match_snapshot's end-to-end paths were tested, but the internals that define snapshot semantics were not. Pin them: - normalize_actual: strips CR and trailing newlines, keeps inner blank lines - match_with_placeholder: ::ignore:: in the middle of a line, spanning multiple lines, rejecting non-matching fixed text, regex metacharacters in snapshots treated literally, and BASHUNIT_SNAPSHOT_PLACEHOLDER overrides - resolve_file: an explicit path hint is used verbatim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
assert_match_snapshot's end-to-end paths are tested, but the internals defining snapshot semantics — the::ignore::placeholder matcher, normalization, path resolution — had no direct coverage.💡 Changes
normalize_actual: CR stripping, trailing-newline trim, inner blank lines preserved.match_with_placeholder: mid-line and multi-line::ignore::, non-matching fixed text rejected, regex metacharacters in snapshots stay literal, customBASHUNIT_SNAPSHOT_PLACEHOLDERhonoured.resolve_file: explicit hint used verbatim.