Skip to content

fix(build): make sa actually fail on shellcheck findings #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chemaclass merged 1 commit into from
Jul 16, 2026
Merged

fix(build): make sa actually fail on shellcheck findings #815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,18 @@ pre_commit/run:
test/parallel: $(TEST_SCRIPTS)
@bash ./bashunit --parallel --simple $(TEST_SCRIPTS)

# sa: xargs (unlike `find -exec {} \;`) propagates shellcheck's exit code, so
# findings actually fail the target; the excludes mirror the CI workflow's
# SHELLCHECK_OPTS for local/CI parity. One file per invocation (like CI's
# action) because shellcheck 0.11.0 can crash on multi-file batches with -x;
# -P 4 keeps the wall time reasonable.
sa:
ifndef STATIC_ANALYSIS_CHECKER
@printf "\e[1m\e[31m%s\e[0m\n" "Shellcheck not installed: Static analysis not performed!" && exit 1
else
@find . -name "*.sh" -not -path "./local/*" -exec shellcheck -xC {} \; && printf "\e[1m\e[32m%s\e[0m\n" "ShellCheck: OK!"
@find . -name "*.sh" -not -path "./local/*" -print0 \
| xargs -0 -n 1 -P 4 shellcheck -xC -e SC1091 -e SC2155 -e SC2016 \
&& printf "\e[1m\e[32m%s\e[0m\n" "ShellCheck: OK!"
endif

lint:
Expand Down
Loading