Fix MessagePack serialization on Node 24 - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin all four auth workspace consumers to MessagePack 1.11.8 and exercise long Unicode, nested and binary payloads through the real crypto APIs. This is the companion dependency update for TryQuiet/quiet#3423's embedded Node 24 migration.
The original failure was MessagePack 1.10.2 passing an out-of-bounds Buffer write length on Node 24. Current
mainalready uses 1.11.2 and passes the baseline; this refresh preserves all current security fixes and retains the migration's tested 1.11.8 pin. Transitive relay dependencies remain unchanged.Six regression tests cover serialization, hashing, signatures and tampering, symmetric encryption, and provided/ephemeral asymmetric sender keys. Signature coverage uses the current required domain-separation context and also rejects verification under another context. No crypto algorithm or wire-protocol implementation changes.
CI uses frozen pnpm 10.6.0 installs and runs the full suite on Node 20 and 24.
Fresh validation at
17e0b5b(2026-09-21):This supersedes the earlier pre-refresh results that reported 88 failures on an older auth baseline. Fresh hosted CI is pending.