Skip to content

Refactor converter.js #14

Description

@kirrg001

Problem

We are currently adding support for filtering on relations.

With every case, the converter becomes:

  • harder to read
  • a little bit hacky to fulfil the cases

Reasons

  • everything lives in one file
  • the relation cases are quite challenging, the complexity is high

Goal

Try to add all relation cases and then refactor the converter.js.
We should first learn from the use cases and see which refactoring direction makes sense.

I think what we need is a detection in the code base what this case is and then react on it.
Currently, the converter.js is too generic, which makes it hard to deal with all the cases.
IMO be explicit and more readable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions