feat(nanoviews): rename $$children, $$slot and $$slots to a trailing $ - #209
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 85.33% 85.30% -0.04%
==========================================
Files 139 139
Lines 3143 3143
Branches 591 591
==========================================
- Hits 2682 2681 -1
Misses 332 332
- Partials 129 130 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…iling `$` Effect attributes moved from `$$name` to `name$` in #188; these three were the last names left with the old prefix, and they are the ones a component author writes most.
dangreen
force-pushed
the
feat/nanoviews-children-postfix
branch
from
August 24, 2026 15:57
57bcfef to
f32e54a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect attributes lost the
$$prefix in #188 and took a trailing$instead —classList$,value$,ref$,autoFocus$. These three kept the old spelling:They are the names a component author writes most, so the inconsistency was in the most visible place.
Cost
None. The package is not published yet, so the old names go rather than turn into aliases, and the rename is free at every measured entry:
The average-usage entry names its imports, so
$$childrenthere becamechildren$too. One brotli pin moves down a step.114 tests, lint and
tsc --noEmitgreen.