Skip to content

fix(kida): type toAccessor by what it actually returns #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangreen merged 1 commit into from
Aug 24, 2026
Merged

fix(kida): type toAccessor by what it actually returns #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/kida/src/internals/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import type {
WritableSignal,
ReadableSignal,
Accessor,
AnyAccessor
AnyFn
} from 'agera'

export type { AnyFn } from 'agera'
Expand Down Expand Up @@ -40,10 +40,13 @@ export type ToSignal<T> = [T] extends [AnyWritableSignal]
? ReadableSignal<V>
: WritableSignal<Exclude<T, AnyAccessorOrSignal>> | ToSignal<Extract<T, AnyAccessorOrSignal>>

export type ToAccessor<T> = [T] extends [AnyAccessor]
// Both of these test any function, not just a zero-argument one: the runtime
// test behind them is `typeof value === 'function'`, so a callback is handed
// back untouched exactly like an accessor is, and the type has to say the same
export type ToAccessor<T> = [T] extends [AnyFn]
? T
: Accessor<Exclude<T, AnyAccessor>> | Extract<T, AnyAccessor>
: Accessor<Exclude<T, AnyFn>> | Extract<T, AnyFn>

export type ToAccessorOrSignal<T> = [T] extends [AnyAccessor]
export type ToAccessorOrSignal<T> = [T] extends [AnyFn]
? T
: WritableSignal<Exclude<T, AnyAccessor>> | Extract<T, AnyAccessor>
: WritableSignal<Exclude<T, AnyFn>> | Extract<T, AnyFn>