test: fail the build on a PackageVersion nothing references - #130
Merged
Merged
Conversation
Central Package Management lets a PackageVersion stand alone, and with CentralPackageTransitivePinningEnabled that looks like a clean way to force a version onto a package nothing declares. Dependabot only updates a PackageVersion it can tie to a PackageReference, so a standalone pin is invisible to it and never moves again. The failure is silent both ways: a frozen pin becomes NU1109 the moment a direct dependency needs a higher version, breaking every dependency PR in the repo, and where the pin holds a security floor the floor stops rising. Both had already happened elsewhere in the workspace. This repo has no orphan pins today. The guard is what keeps it that way. Records Trax.Docs/adr/0015.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Central Package Management lets a PackageVersion stand alone, and with CentralPackageTransitivePinningEnabled that looks like a clean way to force a version onto a package nothing declares. Dependabot only updates a PackageVersion it can tie to a PackageReference, so a standalone pin is invisible to it and never moves again.
The failure is silent both ways: a frozen pin becomes NU1109 the moment a direct dependency needs a higher version, breaking every dependency PR in the repo, and where the pin holds a security floor the floor stops rising. Both had already happened elsewhere in the workspace.
This repo has no orphan pins today. The guard is what keeps it that way. Records Trax.Docs/adr/0015.