feat: add Insert Diagram modal with previews and search filter#190
Open
ThisIs-Developer wants to merge 8 commits into
Open
feat: add Insert Diagram modal with previews and search filter#190ThisIs-Developer wants to merge 8 commits into
ThisIs-Developer wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying markdown-viewer with
|
| Latest commit: |
163c6bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ae21985e.markdown-viewer.pages.dev |
| Branch Preview URL: | https://feature-diagram-insert-modal.markdown-viewer.pages.dev |
Deploying markdownviewer with
|
| Latest commit: |
163c6bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81f5a717.markdownviewer.pages.dev |
| Branch Preview URL: | https://feature-diagram-insert-modal.markdownviewer.pages.dev |
b2ec7d7 to
850cd94
Compare
…section into code and view
…or instant loading
…ffline SVG fallbacks
…s, cachestorage, local neutralino compilation)
66900a3 to
163c6bc
Compare
dac1e92 to
163c6bc
Compare
|
Implemented and pushed the diagram-rendering rewrite in What changed
Root cause fixedThe preview and inserted PlantUML diagrams used different rendering/sizing paths. The final renderer combined engine-specific image assumptions with flex sizing, while the modal normalized SVG independently. The shared pipeline now preserves the renderer's Verification
|
c88a482 to
163c6bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces a new "Insert Diagram" utility button to the editor formatting toolbar. It opens a modal dialog that enables users to browse diagram/chart categories, search/filter template cards, view high-fidelity previews, and insert preset code blocks directly into their Markdown document.
To preserve website performance and loading speeds, diagram cards are rendered using lightweight, theme-aware inline SVGs that scale gracefully, avoiding eager loading of heavy third-party javascript libraries or network requests.
Key Changes
bi-diagram-3) and wired it to open the selection modal in index.html.Verification