Skip to content

sorts: make bogo_sort work with any Comparable, not just int - #15331

Open
Pradhyut21 wants to merge 4 commits into
TheAlgorithms:masterfrom
Pradhyut21:fix/bogo-sort-comparable-typehint
Open

sorts: make bogo_sort work with any Comparable, not just int#15331
Pradhyut21 wants to merge 4 commits into
TheAlgorithms:masterfrom
Pradhyut21:fix/bogo-sort-comparable-typehint

Conversation

@Pradhyut21

Copy link
Copy Markdown

Describe your change:

Updates sorts/bogo_sort.py to use PEP 695 type parameter syntax
so that bogo_sort correctly expresses it can sort any orderable
type, not just integers. Refactors is_sorted() as a typed inner
helper. Adds str and float doctest examples.

Part of #15234

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate improvements.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a brief explanation.

Use a Comparable Protocol + TypeVar bound so that bogo_sort
correctly expresses it can sort any orderable type, not just
integers. Adds string and float doctest examples. Refactors
is_sorted() as an inner helper with proper typing.

Part of TheAlgorithms#15234
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant