sorts: make bogo_sort work with any Comparable, not just int - #15331
Open
Pradhyut21 wants to merge 4 commits into
Open
sorts: make bogo_sort work with any Comparable, not just int#15331Pradhyut21 wants to merge 4 commits into
Pradhyut21 wants to merge 4 commits into
Conversation
Use a Comparable Protocol + TypeVar bound so that bogo_sort correctly expresses it can sort any orderable type, not just integers. Adds string and float doctest examples. Refactors is_sorted() as an inner helper with proper typing. Part of TheAlgorithms#15234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Updates
sorts/bogo_sort.pyto use PEP 695 type parameter syntaxso that
bogo_sortcorrectly expresses it can sort any orderabletype, not just integers. Refactors
is_sorted()as a typed innerhelper. Adds
strandfloatdoctest examples.Part of #15234
Checklist: