Skip to content

sorts: make shell_sort work with any Comparable, not just int - #15326

Open
Pradhyut21 wants to merge 2 commits into
TheAlgorithms:masterfrom
Pradhyut21:fix/shell-sort-comparable-typehint
Open

sorts: make shell_sort work with any Comparable, not just int#15326
Pradhyut21 wants to merge 2 commits into
TheAlgorithms:masterfrom
Pradhyut21:fix/shell-sort-comparable-typehint

Conversation

@Pradhyut21

@Pradhyut21 Pradhyut21 commented Sep 14, 2026

Copy link
Copy Markdown

Describe your change:

Updates sorts/shell_sort.py to use a Comparable Protocol + TypeVar bound so that shell_sort correctly expresses it can sort any orderable type, not just integers. Adds str and float doctest examples.

Part of #15234

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate improvements.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a brief explanation.

@Pradhyut21
sorts: make shell_sort work with any Comparable, not just int
f1cbfd7 
Use a Comparable Protocol + TypeVar bound so that shell_sort
correctly expresses it can sort any orderable type, not just
integers. Adds string and float doctest examples.

Part of TheAlgorithms#15234
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Sep 14, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Sep 14, 2026
@Pradhyut21

Pradhyut21 commented Sep 14, 2026

Copy link
Copy Markdown
Author

This is part of #15234. All CI checks are passing. Ready for review!

@priya-sundaram-dev priya-sundaram-dev mentioned this pull request Sep 14, 2026
Open
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pradhyut21