fix(conversion): prevent Base64Decode panic and Base64Encode input mutation#808
Open
SAY-5 wants to merge 1 commit into
Open
fix(conversion): prevent Base64Decode panic and Base64Encode input mutation#808SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
…tation Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Not up to standards ⛔
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Base64Decodeindexesinput[i+1]/input[i+2]/input[i+3]for every step of 4, so any input whose length is not a multiple of 4 panics withindex out of rangeinstead of returning. The decoder now iterates over whole 4-character groups only, so a malformed-length payload is ignored at the tail rather than reading past the end of the string.Base64Encodepadded short final groups by appending zero bytes to theinputslice. When the caller passes a slice with spare capacity (e.g.Base64Encode(buf[:n])),appendwrites those zeros into the caller's backing array and corrupts data observed through other slice headers. The padding bytes are now read locally, so the argument is left untouched.Added regression tests for both: decoding inputs of length 1, 2, 3 and 5, and encoding a sub-slice whose backing array must remain unchanged.
Closes #807
Checklist
Notes: Guard base64 decode/encode against malformed-length input and caller-slice mutation.