Skip to content

fix(splitter): tests - #253

Open
ShaMan123 wants to merge 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/ifc-splitter-tests
Open

fix(splitter): tests#253
ShaMan123 wants to merge 1 commit into
ThatOpen:mainfrom
ShaMan123:fix/ifc-splitter-tests

Conversation

@ShaMan123

@ShaMan123 ShaMan123 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Resolve the open topics from #197 :

  • stage ordering
  • failing tests

Additional context

I regenrated resources/frags/school_str.frag to match the test:

  importer.addAllAttributes();
  importer.addAllRelations();
  importer.webIfcSettings.COORDINATE_TO_ORIGIN = false;

If that is not desired I can add a build step to the test


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following:

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Follow the Conventional Commits v1.0.0 standard for PR naming (e.g. feat(examples): add hello-world example).
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ShaMan123 ShaMan123 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attributed to claude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant