fix: handle stalled and stale full-page captures - #256
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full-page capture needs an explicit stopping range when a site keeps its loading indicator visible. Some Windows browser builds also return stale window-surface pixels after programmatic scrolling. This change handles these separately while retaining the shared scrolling, tiling and PNG pipeline.
Capture range and diagnostics (all platforms)
--scope currentto capture the initial CSS document height. Defaultfollowcontinues to follow appended content. The CLI refuses to savecurrentunless the extension acknowledges the scope.begin,moveandinspect, without changing the bottom-settling timers duringbegin.loading_stalledafter 30 seconds at an unchanged loading bottom, with an actionable--scope currenthint. Preserve distinct cancellation/interruption reasons and progress. Failed captures save no partial image.Windows Agent screenshot source
captureVisibleTabsource is retained; a failed initial probe falls back to the session renderer.stale_frame. Layout mismatches and stale exposures have separate consecutive-failure counters, so mixed failures cannot produce the wrong recovery reason. Backends are selected before measuring and never switch mid-image.Validation
begin.currentcapture produced a 1563 × 4800 PNG with zero mismatches in the sampled pixel column across all 4800 rows.stale_frameafter the initial accepted frame, before any repeated rows were written; the renderer-backed capture then completed correctly. This is controlled fault injection: the original spontaneous surface-cache fault did not reproduce on this Chrome build.