fix(mrkdwn): keep unmatched __ and ~~ delimiters literal - #6
Merged
Conversation
Follow-up to the #3 review. The unmatched-** fix wasn't applied to the double underscore and double tilde branches: an unmatched `__`/`~~` emitted one literal marker then re-parsed the second as a single-delimiter opener, greedily forming a spurious italic/strikethrough span (e.g. `__foo_bar` -> `_ + _foo_ + bar`). Emit both markers literally and advance by two, matching the `**` fix. Adds regression test unmatched_double_underscore_and_tilde_stay_literal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Sentry review on #3. The unmatched-
**fix landed there, but the same bug exists for double underscore (__) and double tilde (~~) — flagged by Sentry after #3 merged.An unmatched
__/~~emitted one literal marker then re-processed the second character with the single-delimiter logic, which greedily found the next_/~and formed a spurious italic/strikethrough span:__foo_bar→_(literal) +_foo_(italic) +bar❌Fix
Emit both markers literally and advance by two, exactly as the
**branch already does.__foo_barand~~a~bnow stay literal; matched__bold__/~~strike~~still convert.Regression test:
unmatched_double_underscore_and_tilde_stay_literal.🤖 Generated with pi
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.