fix: add Alt modifier to inspect hotkey default to avoid browser conflicts - #357
Merged
Conversation
…licts The previous default (Shift + CtrlOrMeta) overlaps with browser shortcuts for opening links in new tabs (Ctrl/Cmd + Shift + Click in Chrome, Edge, Safari). Adding Alt/Option as a third modifier avoids all known OS, browser, and common web app shortcut collisions.
🦋 Changeset detectedLatest commit: 9d4d3d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 9d4d3d3
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/devtools
@tanstack/devtools-client
@tanstack/devtools-ui
@tanstack/devtools-utils
@tanstack/devtools-vite
@tanstack/devtools-event-bus
@tanstack/devtools-event-client
@tanstack/preact-devtools
@tanstack/react-devtools
@tanstack/solid-devtools
@tanstack/vue-devtools
commit: |
Merged
Collaborator
|
relates to #374 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inspectHotkeyfrom["Shift", "CtrlOrMeta"]to["Shift", "Alt", "CtrlOrMeta"]Ctrl/Cmd + Shift + Click) directly overlaps with browser shortcuts for opening links in new tabs (Chrome, Edge, Safari all useCtrl/Cmd + Shift + Click)Alt/Optionas a third modifier avoids all known OS, browser, and common web app shortcut collisionsDetails
Ctrl + Alt + Shift+ click to inspect⌘ + ⌥ + ⇧+ click to inspectTest plan