Skip to content

Kernel IMU API - #650

Merged
KenVanHoeylandt merged 4 commits into
TactilityProject:mainfrom
Shadowtrance:kernel-imu-api
Sep 11, 2026
Merged

Kernel IMU API#650
KenVanHoeylandt merged 4 commits into
TactilityProject:mainfrom
Shadowtrance:kernel-imu-api

Conversation

@Shadowtrance

@Shadowtrance Shadowtrance commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added a standardized IMU interface for accelerometer, gyroscope, and temperature readings.
    • Added IMU support for BMI270, MPU6886, and QMI8658 sensors.
    • Sensor temperature readings are now available in Celsius.
    • Unsupported readings return an appropriate not-supported status.
  • Changes

    • Replaced combined sensor data reads with separate accelerometer, gyroscope, and temperature operations.
    • Updated supported sensors to use the standardized IMU device type and interface.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3efa3455-8c33-4ef1-9bde-a3130efb0544

📥 Commits

Reviewing files that changed from the base of the PR and between 15e7e2a and e40fc8e.

📒 Files selected for processing (6)
  • Drivers/bmi270-module/source/module.cpp
  • Drivers/bmi270-module/source/symbols.c
  • Drivers/mpu6886-module/source/module.cpp
  • Drivers/mpu6886-module/source/symbols.c
  • Drivers/qmi8658-module/source/module.cpp
  • Drivers/qmi8658-module/source/symbols.c
💤 Files with no reviewable changes (3)
  • Drivers/qmi8658-module/source/symbols.c
  • Drivers/mpu6886-module/source/symbols.c
  • Drivers/bmi270-module/source/symbols.c

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The kernel adds shared IMU data types, callback adapters, an IMU device type, and symbol exports. The BMI270, MPU6886, and QMI8658 drivers replace combined sensor reads with separate accelerometer, gyroscope, and temperature functions. Each driver converts raw register data into scaled sensor values and registers an ImuApi instance.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to e40fc

The reviewed IMU API migration has no verified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a kernel IMU API and integrating IMU drivers with it.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt

Copy link
Copy Markdown
Contributor

Good stuff, thank you!

@KenVanHoeylandt
KenVanHoeylandt merged commit 70af88c into TactilityProject:main Sep 11, 2026
64 checks passed
@Shadowtrance
Shadowtrance deleted the kernel-imu-api branch September 12, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants