added an editorconfig recording the existing formatting conventions - #18
added an editorconfig recording the existing formatting conventions#18dmccoystephenson wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Self-reviewThe full diff was read at the PR head before scoring. Each item below is scored against the diff or against a command whose output was observed this session, not against judgement alone. Universal rubric
Repo-specific rubric
Manual validationThe compile and socket gates are UNVERIFIED in this session. The gate is recorded as UNVERIFIED-not-applicable under the scope rule: nothing under This is nonetheless not a claim that the change is verified by compilation, and the pull request is not proposed for an autonomous merge. FindingsThe rubric produced one finding that is a judgement call rather than a mechanical fix, so it is recorded here instead of being applied.
Two further observations are recorded without being acted on. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
Summary
.editorconfigis added at the repository root, recording the formatting conventions the ten tracked files already follow rather than imposing new ones.end_of_line = lfandcharset = utf-8are applied to all files;indent_style = space,indent_size = 4, andtrim_trailing_whitespace = trueare scoped to*.java.trim_trailing_whitespaceis scoped rather than global becauseLICENSEcarries trailing whitespace on three lines.insert_final_newlineis left unset entirely because the seven.javafiles end without a final newline whileREADME.md,LICENSE, and.gitignoreend with one. Both decisions are explained in a comment inside the file, so that a later reader does not "complete" the config and silently rewrite files this change was not meant to touch.Closes #16
Test plan
What was verified
Every rule the new file states was checked against every tracked file, byte by byte, in this session. The command below was run at the PR head and its real output is pasted:
Every
.javafile therefore satisfies each rule in the[*.java]section, and every tracked file satisfies the[*]section. The singletrailWS=3onLICENSEis precisely the reasontrim_trailing_whitespacewas not applied globally.No build output, no
.classfile, and no scratch file is staged.What was not verified, and why
The compile and socket gates were UNVERIFIED in this session.
javacandjavaare present onPATH, but every invocation of either is denied by this dispatch's command classifier, including the barejavac -versionandjava --versionprobes. This reproduces the block recorded on #9 on 2026-08-26.That gate is recorded as UNVERIFIED-not-applicable for this pull request: nothing under
src/is touched, no check script exists or is added, and this change quotes no build or run command and claims no program output. A conforming editor reading.editorconfigcannot alter a.javafile's compiled behaviour, and the diff is a single new configuration file.Deferred backlog, and why
Every other open issue was deferred for one shared reason: the JDK is not invocable in this dispatch, so none of them can be implemented or validated here. The reason is recorded once, in this pull request, rather than being commented onto six issues individually.
src/, and their reported behaviour is observable only over a real socket.Client.sendAndReceivehas no caller) — filed during this cycle's triage. The dead-code finding itself is source-verified, but either proposed resolution alters the client's send-and-receive path, which needs a socket run to demonstrate.Issue #16, implemented here, was selected precisely because it is the one open item whose evidence is byte-level file inspection rather than program behaviour.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
drafted by Claude on behalf of Daniel Stephenson