Show the fleet, voyage and export record on the career ledger

[dmccoystephenson]

Summary

Thirteen lifetime totals were being tracked on Stats and written into every save file, while two of them were never produced and eleven were never shown. This PR closes both ends of that gap in the one subsystem.

The two dead totals are now recorded. totalHaulingContracts and totalTransportRuns had no assignment anywhere in src/ — permanently zero — even though runDailyProduction already routes a piracy boat through _runPiracyDay (which fills raidDays) and a freight or passenger boat through _runHonestDay (which recorded nothing role-specific). _runHonestDay now counts the day under its own role, so freight and passenger work leave the same record piracy already did. Populating the fields was preferred over deleting them precisely because deletion would have meant touching schemas/stats.json and a *JsonReaderWriter — save-file-compatibility-sensitive paths this change deliberately avoids.

The ledger now shows what the boats did. Home._statsLines() — reached via See Stats, and reused by the retirement summary — is the only career ledger in the game, and it named gambling and bank interest while leaving exporting, captaining and piracy invisible. A Fleet: block and an Exports: block have been added, plus the drunken losses beside the existing gambling line. Four milestones are thresholds on totals that were previously unshown (Scourge of the Coast, Coastal Trader, A Fleet in Truth, Old Hand at the Wheel), so progress toward them was readable only as an unticked box.

Both blocks are gated on the lifetime totals rather than on what the player owns today, so a career that ended in a sold-off fleet still shows the fleet's record; a zero entry is dropped and a block with nothing left in it is omitted entirely, which is how the existing business and investment blocks behave. A brand-new game's ledger is therefore unchanged.

Two money lines now keep their cents. An export market pays a fractional multiplier (1.2 / 1.5 / 2.0), so gross — and with it totalMoneyMade and totalMoneyFromExports — is a float. %d was silently truncating it, leaving the ledger permanently disagreeing with the $%.2f the status header shows. The other %d money lines in the ledger were each traced to integer-only sources and left alone.

Test plan

• python3 -m pytest under the dummy SDL drivers: 843 passed, up from 829 on main (14 new tests, 0 failures)
• python3 -m compileall -q src clean
• Each new day-counting test confirmed to fail with the _runHonestDay change stashed, and to pass with it restored
• Each new ledger test confirmed to fail with the _statsLines change stashed, and to pass with it restored
• black run against the four changed files only; no unrelated file was reformatted
• No persisted field added, removed or retyped — schemas/*.json and both *JsonReaderWriters are untouched, so existing saves load exactly as before

Closes #180
Closes #181
Closes #182

Deferred this cycle

No other issue was open at triage; all three closed here were filed during this cycle's scan. One candidate examined and rejected rather than filed: the tavern's Current Bet: $%d looked like the same float-truncation bug, but changeBet forces the bet integral with self.amount = int(amount) (src/location/tavern.py:286), so the display is correct as written.

---

This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

---

drafted by Claude on behalf of Daniel Stephenson

[dmccoystephenson]

Self-review

Scored adversarially against the diff and against command output, not against intent.

Universal rubric

• Scope: PASS — five files, each traceable to a closed issue. src/business/boats.py and tests/business/test_boats.py are totalHaulingContracts and totalTransportRuns are persisted but never incremented #181; src/location/home.py and tests/location/test_home.py are The career ledger never shows the export, voyage, and piracy totals the game tracks #180 and The career ledger truncates Total Money Made, which is a float once fish are exported #182; README.md is the Phase 7 docs pass on The career ledger never shows the export, voyage, and piracy totals the game tracks #180. black was run against the changed files only, and git diff --name-only origin/main...HEAD lists nothing else.
• Tests-new: PASS — one new method was added, Home._careerBlock. It is exercised in both directions: test_displayStats_includes_the_fleet_block_once_the_boats_have_worked covers a populated block, test_displayStats_fleet_block_omits_the_roles_never_worked covers per-entry dropping, and test_displayStats_omits_the_fleet_and_export_blocks_for_a_fresh_player covers the whole-block drop.
• Tests-fix: PASS — verified empirically, not reasoned. With src/business/boats.py and src/location/home.py reverted to origin/main, the new tests were run: 13 failed, 109 passed, and every one of the 13 was a test added by this PR. Restoring both files returned the suite to all-green. The later business-block-gate test was checked the same way in isolation and fails without its fix.
• Sibling structure: PASS — no new file was created. The appended tests follow the surrounding # prepare / # call / # check structure and reuse the existing createHome() and crewedFleet() factories rather than hand-rolling fixtures.
• Sibling renames: PASS — nothing was renamed; _runHonestDay and _runPiracyDay keep their names and their parallel shape.
• Docs: PASS — every row of the sources-of-truth table was checked. README.md gained a paragraph describing the ledger (previously undocumented). schemas/stats.json needs no change and none was made: totalHaulingContracts and totalTransportRuns are already declared integer, and their existing descriptions — "The lifetime number of hauling contracts completed" / "…passenger transport runs completed" — match precisely what is now recorded, which independently corroborates the intended semantics. totalMoneyMade and totalMoneyFromExports are already declared number, corroborating The career ledger truncates Total Money Made, which is a float once fish are exported #182's float claim. PLANNING.md's one open Maybe (fishMultiplier as a chance thing) is untouched by this work. version.txt was left alone; this is polish, not a release.
• Issue resolution: PASS — totalHaulingContracts and totalTransportRuns are persisted but never incremented #181's named surface (_runHonestDay, and the stats block in runDailyProduction) is changed; The career ledger never shows the export, voyage, and piracy totals the game tracks #180's named surface (Home._statsLines) is changed and now reads all eleven previously-unshown totals; The career ledger truncates Total Money Made, which is a float once fish are exported #182's named line is changed. None is partially resolved.
• CI: PASS — test green on head 22e99d1. Locally, 845 tests executed and passed under the dummy SDL drivers, against 829 on main.

Repo-specific rubric

• Schema-sync: PASS (vacuously) — no persisted field was added, removed or retyped, and no *JsonReaderWriter was touched. Existing saves load exactly as before, which is the whole reason totalHaulingContracts and totalTransportRuns are persisted but never incremented #181 was resolved by populating the two dead fields rather than deleting them.
• Money-format: PASS — totalMoneyMade and totalMoneyFromExports are rendered %.2f; both were traced to the float gross in export.py. The other money lines were each traced to an integer-only source and deliberately left on %d: moneyMadeFromInterest (int(math.ceil(...))), moneyLostFromGambling (bet forced integral by int(amount)), totalRentPaid, totalWagesPaid, totalRentalIncome, totalPlunder and totalMoneyFromVoyages (all integer sources — voyage takings come from random.randint or an explicit int(...)).
• Deterministic-tests: PASS — the one new test whose path touches randomness, test_fishing_and_piracy_days_are_not_counted_as_honest_work, patches both random.random and random.randint so no raid damage or fatality can perturb the assertion. The rest set stat values directly and roll no dice.
• Headless-pygame: PASS, with the scope stated — no pygame code path was changed. The ledger does get up to twelve lines longer, and PygameUserInterface.showDialogue was read to confirm that case is already handled: _dialogueScrollBounds/_dialogueHint scroll a dialogue taller than the window, with a docstring naming "the stats and retirement screens" as the reason. The whole suite, including the pygame tests, runs under SDL_VIDEODRIVER=dummy SDL_AUDIODRIVER=dummy.
• camelCase: PASS — _careerBlock, valueFormat, haulingDays, transportDays.

Findings raised and acted on during the review

• src/location/home.py:223 — the Fleet block is gated on lifetime totals while the business block above it was gated on player.hasBoat, so a player who sold off their fleet would have been shown its takings without the wages those takings were earned against. Fixed in 3ae5a1a, with a regression test confirmed to fail without it.

Judgment calls left standing, disclosed rather than silently taken

• _careerBlock drops a zero entry, so a captain with a clean record sees no Voyages Foundered: 0. This is deliberate and matches how Lifetime Rent Paid already behaves, but it does mean the ledger cannot distinguish "never foundered" from "the game does not track that". Reversing it would mean showing zeroes for every role the player has never touched, which is the wall-of-zeroes the block gating exists to avoid.
• Money From Boat Work renders totalMoneyFromVoyages, which mixes the fleet's own working days with voyages the player captained — that is genuinely what the stat holds (see the comment on it in stats.Stats), so the label was chosen to span both rather than implying either one alone. Splitting the stat would be a persistence change and is out of scope here.

---

This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).

---

drafted by Claude on behalf of Daniel Stephenson