Fix HyperTreeSTL short-horizon forecasts#12
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 970ce1bac6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Thanks a lot for the detailed report in #10 and for taking the time to put up a fix with tests, @janrth, really appreciated. It turns out this same short-horizon crash was already addressed independently on our conformal branch back in 8c186ed (2026-06-10), as part of the STL rework. That branch applies the same three fixes you identified:
Because the two fixes overlap, I'm going to close this PR as superseded to avoid a conflicting duplicate, but your end-to-end fcst_h=3 / fcst_h=1 regression tests are actually a nicer, more faithful guard than the unit-level test currently on conformal, so I'd like to encouruage you to open a new PR with the test only. |
Fixes #10.
Summary
fcst_h=3andfcst_h=1.Tests
.venv/bin/python -m pytest tests/test_hypertree_stl.py -q.venv/bin/python -m pytest -q