Harden cached release asset handling#9
Conversation
Oleg-Melnik
left a comment
There was a problem hiding this comment.
Substantial and careful rework of the install/cache trust model. The file-handling hardening (NOFOLLOW everywhere, per-component link rejection, Windows-junction detection, containment re-checks after moves) and the test additions (symlink/junction rejection, tampered-asset-with-rewritten-sidecar, permission restore, staged-temp cleanup, portable/case-distinct cache keys, deterministic HTTP assertions) are the strongest parts. No correctness bugs spotted. Inline comments are two behavior/trust-model decisions to confirm-and-document, one definite doc defect, two doc-content losses, and one cleanup. I reviewed the diff only; I did not run the build or tests.
Oleg-Melnik
left a comment
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with comments to address.
This PR: