-
Notifications
You must be signed in to change notification settings - Fork 0
Provide app version validation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e48a1cb
Secure app version.
Vladyslav-Kuksiuk 4fd76ce
Secure paths.
Vladyslav-Kuksiuk a37e752
Make version treatment as release tag.
Vladyslav-Kuksiuk 8e2aa29
Bump version -> `0.1.1`.
Vladyslav-Kuksiuk 8e956a7
Improve readability.
Vladyslav-Kuksiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verbatim-tag semantics are a behavioral break for existing configurations:
version.set("1.2.4")used to be auto-prefixed tov1.2.4, and after this change it requests a tag literally named1.2.4, which fails at download with a message that gives no hint about the removed convention. The README documents the new behavior well, but nothing helps someone upgrading.Cheap mitigations, either or both:
vautomatically; set the exact tag now");v, append a hint to the error: "a release tagv<tag>may exist — previous plugin versions added this prefix automatically."Related one-liner: the pinned cache moved from
build/embed-code/<version>tobuild/embed-code/versions/<tag>, so caches from earlier plugin versions are orphaned (self-heals via one re-download; stale directories linger until aclean). Not worth documenting for end users, but worth knowing it's expected.