Provide binaries integrity verification#5
Merged
Conversation
Vladyslav-Kuksiuk
marked this pull request as ready for review
July 21, 2026 13:06
Oleg-Melnik
reviewed
Jul 21, 2026
Oleg-Melnik
left a comment
Oleg-Melnik
left a comment
Collaborator
There was a problem hiding this comment.
This lands the integrity story well: fail-closed SHA-256 verification of the downloaded asset, digest auto-resolution from the GitHub Releases API, source-identity binding of the cache (base URL + asset name), offline reuse gated on re-hashing the executable, and an explicit-opt-in token that is proven by test not to leak in from the ambient GITHUB_TOKEN. The metadata-write-after-atomic-move ordering also fails in the safe direction (a crash leaves an untrusted cache that gets re-downloaded). Inline comments below are hardening and UX-level; none are blockers.
Oleg-Melnik
approved these changes
Jul 21, 2026
Oleg-Melnik
left a comment
Oleg-Melnik
left a comment
Collaborator
There was a problem hiding this comment.
@Vladyslav-Kuksiuk LGTM with comments to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides binaries integrity verification before execution.
Also, adds GitHub authorization token provisioning for Embed-Code downloads via CI.