Skip to content

Implement Embed-Code Gradle plugin#2

Merged
Vladyslav-Kuksiuk merged 15 commits into
masterfrom
provide-gradle-plugin
Jul 17, 2026
Merged

Implement Embed-Code Gradle plugin#2
Vladyslav-Kuksiuk merged 15 commits into
masterfrom
provide-gradle-plugin

Conversation

@Vladyslav-Kuksiuk

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

This PR implements the Embed-Code Gradle plugin.

@Vladyslav-Kuksiuk Vladyslav-Kuksiuk self-assigned this Jul 14, 2026
# Conflicts:
#	.github/workflows/check.yml
Base automatically changed from init to master July 16, 2026 07:43
@Vladyslav-Kuksiuk
Vladyslav-Kuksiuk marked this pull request as ready for review July 16, 2026 12:48

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline findings from a second-pass review. Overall the update looks strong — the latest-release caching redesign and its test coverage are a clear improvement.

Comment thread gradle-plugin/src/main/kotlin/io/spine/embedcode/gradle/InstallEmbedCodeTask.kt Outdated
Comment thread README.md Outdated
Comment thread gradle-plugin/src/main/kotlin/io/spine/embedcode/gradle/EmbedCodePlugin.kt Outdated

@Oleg-Melnik Oleg-Melnik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vladyslav-Kuksiuk LGTM with some comments to address.

@Vladyslav-Kuksiuk
Vladyslav-Kuksiuk merged commit e02c5e9 into master Jul 17, 2026
2 checks passed
@Vladyslav-Kuksiuk
Vladyslav-Kuksiuk deleted the provide-gradle-plugin branch July 17, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants