fix: escape cypher debug statement with comments across newlines BED-9065 - #111
Open
computator wants to merge 3 commits into
Open
fix: escape cypher debug statement with comments across newlines BED-9065#111computator wants to merge 3 commits into
computator wants to merge 3 commits into
Conversation
computator
added
bug
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
ChangesCypher comment safety
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
computator
marked this pull request as ready for review
August 5, 2026 01:00
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cypher/models/pgsql/translate/format_test.go`:
- Around line 30-37: Update the line-validation loop in the format test to
assert that every non-boundary line before the “with s0” sentinel begins with
the “--” comment prefix, rather than only checking that it does not contain
“fail”; retain skipping comment lines and the existing boundary behavior as
appropriate.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b62577ef-4fcb-4e59-9a60-f8dceaad389e
📒 Files selected for processing (2)
cypher/models/pgsql/translate/format.gocypher/models/pgsql/translate/format_test.go
urangel
reviewed
Aug 5, 2026
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestFromCypherProperlyEscapesDebugComment(t *testing.T) { |
Contributor
There was a problem hiding this comment.
suggestion(non-blocking): It would be nice to add the requested tests for matcher keys containing -- and /* */. The approach does already handle them it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves: BED-9065
Type of Change
Testing
make test_allwithCONNECTION_STRINGset)Screenshots (if appropriate):
Driver Impact
drivers/pg)drivers/neo4j)Checklist
go.mod/go.sumare up to date if dependencies changedSummary by CodeRabbit
Bug Fixes
Tests