Skip to content

Add should_not_sleep check version options - #479

Merged
SpaceManiac merged 11 commits into
SpaceManiac:masterfrom
ZeWaka:zw/add-sleepcheck-v1-option
Sep 14, 2026
Merged

Add should_not_sleep check version options#479
SpaceManiac merged 11 commits into
SpaceManiac:masterfrom
ZeWaka:zw/add-sleepcheck-v1-option

Conversation

@ZeWaka

@ZeWaka ZeWaka commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Adds a new config for SpacemanDMM_should_not_sleep:

Basically, only things like src.proc(), global/self calls, ..(), and terms proven to refer to src.

v3 ignores the case (which is valid! just very noisy in ss13) of

/proc/perform(atom/A)
    set SpacemanDMM_should_not_sleep = TRUE
    var/atom/B = A
    B.overridden_proc()

/atom/proc/overridden_proc()
    return

/atom/foo/overridden_proc()
    sleep(1)

Goon had hundreds on v2, tg had as well - also just from the first pass, not all errors show at once.
With v3, goonstation has 0 and tgstation has 6 seemingly valid ones. Mostly in martial arts code.

@ZeWaka
ZeWaka force-pushed the zw/add-sleepcheck-v1-option branch from db4db82 to 4903f99 Compare September 13, 2026 01:42
Comment thread crates/dreamchecker/src/lib.rs
Comment thread crates/dreamchecker/src/lib.rs Outdated
@ZeWaka
ZeWaka marked this pull request as ready for review September 13, 2026 05:50
@SpaceManiac

Copy link
Copy Markdown
Owner

6-8 diagnostics is much more practical to dump on people than 100+, thanks for the middle ground. I've changed the default from 2 to 3.

@SpaceManiac SpaceManiac changed the title Adds should_not_sleep configuration and new version Add should_not_sleep check version options Sep 14, 2026
@SpaceManiac
SpaceManiac merged commit 77eee13 into SpaceManiac:master Sep 14, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants