Add should_not_sleep check version options - #479
Merged
SpaceManiac merged 11 commits intoSep 14, 2026
Conversation
only follows chains on `src`/self-calls
ZeWaka
force-pushed
the
zw/add-sleepcheck-v1-option
branch
from
September 13, 2026 01:42
db4db82 to
4903f99
Compare
ZeWaka
commented
Sep 13, 2026
ZeWaka
marked this pull request as ready for review
September 13, 2026 05:50
Owner
|
6-8 diagnostics is much more practical to dump on people than 100+, thanks for the middle ground. I've changed the default from 2 to 3. |
should_not_sleep configuration and new versionshould_not_sleep check version options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new config for
SpacemanDMM_should_not_sleep:Basically, only things like
src.proc(), global/self calls,..(), and terms proven to refer tosrc.v3 ignores the case (which is valid! just very noisy in ss13) of
Goon had hundreds on v2, tg had as well - also just from the first pass, not all errors show at once.
With v3, goonstation has 0 and tgstation has 6 seemingly valid ones. Mostly in martial arts code.