Fix Editor Duplication and improve styles #210
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the Source Pane layout/styling and removes a lifecycle path that could trigger duplicate editor initialization, aligning the UI structure with the SourceProvider wrapper component.
Changes:
- Restructured layout responsibilities by moving the flex/padding/gap layout from
.sourcePaneonto the<source-pane-source-provider>host element. - Removed
updated()-time editor initialization inSourceEditorCardto prevent duplicate editor creation. - Improved editor sizing/fit by adding a minimum height theme in CodeMirror and updating editor container CSS.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/sourcePane.css | Moves layout/padding/gap to the provider host and simplifies .sourcePane container styling. |
| src/components/source-provider/SourceProvider.ts | No functional change (formatting only). |
| src/components/source-editor-card/SourceEditorCard.ts | Removes updated() initialization path to avoid duplicate editor initialization. |
| src/components/source-editor-card/SourceEditorCard.styles.css | Updates editor container sizing and removes card-level padding/background styles from the section wrapper. |
| src/components/source-editor-card/SourceEditor.ts | Adds a CodeMirror theme rule to enforce a minimum editor height. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…istry@3.1.2-2 solid-ui@3.1.3-13) (latest: rdflib@2.4.0)
timea-solid
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix editor dupication and improving styling.