-
Notifications
You must be signed in to change notification settings - Fork 46
delete footer #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
delete footer #829
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
53373e3
delete footer
timea-solid d6d0d57
remo traces of the old footer web component
timea-solid f895bc2
Update ci.yml
bourgeoa 0a34945
Merge pull request #838 from SolidOS/bourgeoa-gh-pages-staging
bourgeoa 89b8e33
deleted wrongly copied file
timea-solid 6ba53fc
chore: update solidos dependencies (dev: solid-logic@4.0.8-1 pane-reg…
github-actions[bot] 5deda64
updated lock
timea-solid 9be4525
Merge remote-tracking branch 'origin/main' into newLayout
timea-solid 95924d5
merge staging
timea-solid 38d1d14
chore: update solidos dependencies (dev: solid-logic@4.0.8-1 pane-reg…
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok to remove these comments? They are still part of the "prompt history", even if the code they generated is now removed.
I don't like these here either, to be honest, but if we want to keep prompt history it should be exhaustive. Maybe we can just move the to a separate .md file outside of the README or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should delete the prompts everywhere in the end. this approach was not ok. for now I deleted the prompts that I used to create the files I deleted.