Skip to content

EBP-2849: Enforce plugin version bumps on release PRs and marketplace sync (#2) - #1

Closed
aelsammak wants to merge 2 commits into
SolaceProducts:mainfrom
SolaceDev:dev
Closed

EBP-2849: Enforce plugin version bumps on release PRs and marketplace sync (#2)#1
aelsammak wants to merge 2 commits into
SolaceProducts:mainfrom
SolaceDev:dev

Conversation

@aelsammak

Copy link
Copy Markdown
Collaborator
  • Add tools/check-plugin-versions.sh requiring a strict semver bump in plugin.json when plugin content (excluding the top-level evals/ corpus) changes relative to the PR base
  • Gate the version check to PRs targeting main, matching the EBP-2829 decision that bumps happen only in release PRs
  • Validate marketplace.json stays in sync with plugins/ on every run: entries resolve to existing plugin dirs, names match, no duplicates, every plugin dir listed
  • Wire both checks into the validate CI job as steps; checkout uses fetch-depth 0 so the merge base is reachable
  • EBP-2849: Address Claude PR review fixes

  • EBP-2849: Bump setup-node from Node 20 to Node 24

  • Node 20 reached end of life in April 2026 and GitHub Actions runners remove it in fall 2026
  • Node 24 is the active LTS and satisfies the Claude Code CLI requirement of Node 18 or newer
  • Applies to both setup-node usages (validate and trigger-evals jobs)

… sync (#2)

* EBP-2849: Enforce plugin version bumps on release PRs and marketplace sync

- Add tools/check-plugin-versions.sh requiring a strict semver bump in plugin.json when plugin content (excluding the top-level evals/ corpus) changes relative to the PR base
- Gate the version check to PRs targeting main, matching the EBP-2829 decision that bumps happen only in release PRs
- Validate marketplace.json stays in sync with plugins/ on every run: entries resolve to existing plugin dirs, names match, no duplicates, every plugin dir listed
- Wire both checks into the validate CI job as steps; checkout uses fetch-depth 0 so the merge base is reachable

* EBP-2849: Address Claude PR review fixes

* EBP-2849: Bump setup-node from Node 20 to Node 24

- Node 20 reached end of life in April 2026 and GitHub Actions runners remove it in fall 2026
- Node 24 is the active LTS and satisfies the Claude Code CLI requirement of Node 18 or newer
- Applies to both setup-node usages (validate and trigger-evals jobs)
…CLI install (#3)

- Pin actions/checkout, setup-node, setup-java, and upload-artifact to the full commit SHAs their v4 tags currently resolve to, with the tag in a trailing comment
- Pin the Claude Code CLI install to 2.1.231 via a workflow-level CLAUDE_CODE_VERSION env value shared by both install steps
- Mutable tags and unpinned npm installs let a compromised upstream publish execute in CI; the trigger-evals job holds the ANTHROPIC_API_KEY secret
@aelsammak aelsammak closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant