fix(firewall): pin sfw v1.15.2 and retry transient download failures - #17
Draft
Ruxandra Fediuc (ruxandrafed) wants to merge 1 commit into
Draft
Ruxandra Fediuc (ruxandrafed) wants to merge 1 commit into
Ruxandra Fediuc (ruxandrafed) wants to merge 1 commit into
Conversation
The pinned release was v1.15.0, and the checksum table only covers the pinned release, so `firewall-version` could not reach any other build: an explicit `1.15.2` downloaded that binary and then failed validation against the v1.15.0 hash. The Windows command-resolution fix released in v1.15.2 was therefore unreachable through this action. Downloads also had no retry beyond the three attempts `downloadTool` makes on its own, roughly 40 seconds against a single origin. A GitHub release-asset 504 outlives that and fails the whole job, which is what drove repeated CI re-runs. Attempts are now layered on top, skipping the 4xx codes that will not change on a retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two problems with how the action installs the firewall binary.
The pin was
v1.15.0and the checksum table only covers the pinned release, so no other version was installable:firewall-version: 1.15.2downloaded that binary and then failed validation against the v1.15.0 hash, whilelatestquietly resolved to the pin rather than the newest release. This bumps the pin tov1.15.2and recomputes all twelve checksums from the published assets.Downloads also had no retry beyond the three attempts
downloadToolmakes internally, roughly 40 seconds against a single origin. A 504 from GitHub release assets outlives that and fails the whole job. Attempts are now layered on top, 30s then 60s, skipping the 4xx codes that will not change on a retry.dist/is rebuilt, which also clears the standingcheck: distfailure on main.ci: gatesstays red here for unrelated fleet-payload drift that predates this branch.