Prompt for store create dev flags in TTY, require them in non-TTY#7920
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
amcaplan
force-pushed
the
store-create-dev-prompt-or-require
branch
2 times, most recently
from
c0372a3 to
9230ad6
Compare
github-actions
Bot
added
no-changelog
Make --name, --organization-id, and --plan required only in non-interactive environments via failMissingNonTTYFlags. In TTY environments, prompt for any missing value: text prompt for name, existing org selector (selectOrg), and a list selector for plan. Regenerated oclif.manifest.json to reflect the flags no longer being unconditionally required. Assisted-By: devx/ae84811a-733c-4815-8d7d-604504428a4b
amcaplan
force-pushed
the
store-create-dev-prompt-or-require
branch
from
9230ad6 to
a41813a
Compare
alfonso-noriega
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Per the spec,
store create devshould treat--organization-id,--name, and--planas required only when there's no TTY to prompt in. Previously--organization-idwasn't required at all, and--name/--planwere always required, so interactive users couldn't be prompted for them.WHAT is this pull request doing?
--name,--organization-id, and--planrequired only in non-interactive (non-TTY) environments viathis.failMissingNonTTYFlags(flags, ['name', 'organization-id', 'plan']).PLAN_LABELSmap (Basic / Grow / Advanced / Plus)packages/store/src/cli/prompts/store.ts(storeNamePrompt,storePlanPrompt) to match the repo'sprompts/convention.How to test your changes?
shopify store create devin a terminal with no flags → it should prompt for organization, name, and plan.Checklist
minorbump, changeset added