Skip to content

Recognize Ghostty terminal hyperlinks#7918

Merged
alfonso-noriega merged 1 commit into
mainfrom
06-24-recognize_ghostty_terminal_hyperlinks
Jun 24, 2026
Merged

Recognize Ghostty terminal hyperlinks#7918
alfonso-noriega merged 1 commit into
mainfrom
06-24-recognize_ghostty_terminal_hyperlinks

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

Ghostty supports terminal hyperlinks, but the CLI currently resolves supports-hyperlinks to 3.1.0, which does not recognize TERM_PROGRAM=ghostty.

WHAT is this pull request doing?

Updates the root supports-hyperlinks resolution from 3.1.0 to 3.2.0, which recognizes Ghostty as hyperlink-capable while keeping the CommonJS-compatible API shape used by older transitive consumers.

This intentionally does not update to latest 4.5.0 because that version is ESM-only and would be riskier while @shopify/cli-hydrogen still brings in @oclif/core@3.26.5.

A patch changeset is included for @shopify/cli-kit.

How to test your changes?

  • pnpm install --frozen-lockfile
  • pnpm --filter @shopify/cli-kit type-check
  • pnpm --filter @shopify/cli-kit lint
  • pnpm --filter @shopify/cli-kit vitest -- src/private/node/ui/components/Link.test.tsx src/private/node/ui/components/TokenizedText.test.tsx src/public/node/ui.test.ts
  • TERM_PROGRAM=ghostty FORCE_COLOR=1 pnpm --filter @shopify/cli-kit exec node -e "const {supportsHyperlink}=require('supports-hyperlinks'); if (!supportsHyperlink({isTTY:true})) throw new Error('Ghostty should support hyperlinks'); console.log('Ghostty hyperlink support detected')"
  • git diff --check

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/3c9d2be5-81a1-4ad5-90ba-4155c6ff125d
@alfonso-noriega alfonso-noriega requested review from a team as code owners June 24, 2026 15:33
@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Jun 24, 2026
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jun 24, 2026
Merged via the queue into main with commit d4d3e1d Jun 24, 2026
50 of 52 checks passed
@alfonso-noriega alfonso-noriega deleted the 06-24-recognize_ghostty_terminal_hyperlinks branch June 24, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants