Make metadata timer tests deterministic#7917
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/3c9d2be5-81a1-4ad5-90ba-4155c6ff125d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
The metadata timer tests used short real sleeps to create measurable durations. Those sleeps make the tests depend on scheduler timing even though the behavior under test only needs elapsed
performance.now()values.WHAT is this pull request doing?
Replaces the real sleeps in the nested metadata timer tests with a tiny mocked performance clock. The tests now advance the clock explicitly while keeping the same nested timer structure and performance measure assertions.
No changeset is included because this is test-only maintenance with no user-facing behavior change.
How to test your changes?
pnpm --filter @shopify/cli-kit vitest -- src/public/node/metadata.test.tspnpm --filter @shopify/cli-kit type-checkpnpm --filter @shopify/cli-kit lintgit diff --checkPost-release steps
None.
Checklist