Render store info details as a data table with link footnotes#7914
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the readability of shopify store info text output by rendering “Store details” as a two-column table and ensuring long store URLs don’t wrap inside the bordered banner (instead appearing as link footnotes).
Changes:
- Replace the “Store details” list banner section with
TabularData-backed[label, value]rows (with subdued first column). - Render Admin/Access/Save URLs as link tokens so banners emit compact
Link [n]references with footnoted full URLs. - Update unit tests and add a patch changeset for
@shopify/store.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/store/src/cli/services/store/info/result.ts | Switch store details rendering from a list to tabularData rows and convert URL values to link tokens for footnotes. |
| packages/store/src/cli/services/store/info/result.test.ts | Update assertions to validate row-based tabularData output and link-token URL rows. |
| .changeset/store-info-data-table.md | Patch changeset documenting the user-facing output change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| @@ -2,6 +2,7 @@ import {outputResult} from '@shopify/cli-kit/node/output' | |||
| import {renderInfo} from '@shopify/cli-kit/node/ui' | |||
| import {capitalizeWords} from '@shopify/cli-kit/common/string' | |||
| import type {StoreInfoResult, StoreInfoStoreOwner} from './types.js' | |||
| import type {InlineToken} from '@shopify/cli-kit/node/ui' | |||
amcaplan
force-pushed
the
store-info-link-tokens
branch
from
a34ca8e to
8e0cea8
Compare
URLs (Admin, Access, Save) in the store info command wrapped awkwardly inside renderInfo's bordered box, interleaving URL text with box characters. Rendering them as link tokens lets the UI kit's footnote system print full URLs outside the box, fixing the layout. Assisted-By: devx/19f4c9df-1fa8-4696-9c82-8f5f86ac69da
Switch the 'store info' Store details section from a list to a TabularData two-column [label, value] table. URL values remain link tokens so the banner's LinksContext renders them as compact footnote references inside the box with the full URL outside it.
Assisted-By: devx/077d295d-2405-4b15-92b2-4c6a72aa41f1
…periods Assisted-By: devx/ae84811a-733c-4815-8d7d-604504428a4b
amcaplan
force-pushed
the
store-info-link-tokens
branch
from
8e0cea8 to
7479589
Compare
alfonso-noriega
approved these changes
Jun 24, 2026
alfonso-noriega
left a comment
alfonso-noriega
left a comment
Contributor
There was a problem hiding this comment.
Great update. Looking forward to see this live!
tizmagik
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
store infocommand rendered the Store details section as a plainlist inside a bordered
renderInfobanner. The URL fields (Admin URL,Access URL, Save URL) were plain strings, so long URLs wrapped inside the
box and interleaved with the border characters (
│), making the outputunreadable.
WHAT is this pull request doing?
Two related changes to
packages/store/src/cli/services/store/info/result.ts:tokens. Because the banner provides a
LinksContext, each URL shows acompact
Link [n]reference inside the box and the full URL prints as afootnote outside the box, where it can wrap freely without breaking the
border.
TabularDatacomponent as a two-column[label, value]table(
firstColumnSubdued) instead of a flat list.Tests updated in
result.test.tsto assert the new row-based structure.How to test your changes?
shopify store infoagainst a store (or the relevant dev flow).Link [n]inside the box and the full URLsappear as footnotes below the box — no wrapping into the border.
Checklist
patchchangeset for@shopify/store