Remove ellipsis from preview store creation task#7913
Merged
Conversation
Assisted-By: devx/c4031af8-816c-4935-976b-42b220f2f7bf
github-actions
Bot
added
the
no-changelog
amcaplan
approved these changes
Jun 24, 2026
amcaplan
reviewed
Jun 24, 2026
|
|
||
| const result = await renderSingleTask<CreatePreviewStoreResult>({ | ||
| title: outputContent`Creating store…`, | ||
| title: outputContent`Creating store`, |
Contributor
There was a problem hiding this comment.
Is outputContent even necessary here?
Contributor
Author
There was a problem hiding this comment.
That is the standard cli approach to static messages:
title: outputContent`Authenticating`
title: outputContent`Executing GraphQL operation`
title: outputContent`Starting bulk operation`
title: outputContent`Polling bulk operation`
title: outputContent`Uploading bulk operation variables`
title: outputContent`Loading application`
title: outputContent`Loading stored store auth`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add