Skip to content

[Refactor] Use flatMap and uniq in scopes.ts#7882

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-use-flatmap-and-uniq-in-scopes-6324310727239827257
Draft

[Refactor] Use flatMap and uniq in scopes.ts#7882
gonzaloriestra wants to merge 1 commit into
mainfrom
refactor-use-flatmap-and-uniq-in-scopes-6324310727239827257

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

This PR refactors packages/cli-kit/src/private/node/session/scopes.ts to improve code readability and maintainability by:

  • Replacing the verbose .map().flat() pattern with the more modern .flatMap().
  • Replacing manual array deduplication using Array.from(new Set(...)) with the project-standard uniq() utility.

Behavior remains exactly the same, as verified by existing unit tests.

How to test your changes?

CI


PR created automatically by Jules for task 6324310727239827257 started by @gonzaloriestra

- Replace .map().flat() with .flatMap() in allDefaultScopes
- Replace manual Set-based deduplication with uniq() helper in allDefaultScopes and apiScopes
- Import uniq from @shopify/cli-kit/common/array
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant