Omit admin URL for preview stores in store info#7858
Merged
Conversation
github-actions
Bot
added
the
no-changelog
alfonso-noriega
approved these changes
Jun 18, 2026
alfonso-noriega
left a comment
alfonso-noriega
left a comment
Contributor
There was a problem hiding this comment.
small naming change, but otherwise every thing is perfect
| subdomain: SHOP, | ||
| adminUrl: 'https://admin.shopify.com/store/shop', | ||
| accessUrl: 'https://app.shopify.com/auth/preview-store?token=fresh-access-token', | ||
| claimUrl: 'https://admin.shopify.com/store-transfer/accept/claim-token', |
Contributor
There was a problem hiding this comment.
lets refrase this to match the oficial new user facing save url
| displayName: previewSession.preview.name, | ||
| adminUrl: buildAdminUrl(extractMyshopifyHandle(store)), | ||
| accessUrl: previewStoreUrls.accessUrl, | ||
| claimUrl: previewStoreUrls.claimUrl, |
Contributor
There was a problem hiding this comment.
same here, save url is the official term now
The admin URL doesn't resolve for an unclaimed preview store, so drop it from the preview-store result. Preview stores already get their info from the stored session + claim/access URLs (not StoreInfoAdminShopQuery), so partnerDevelopment was never queried for them and needs no change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
amcaplan
force-pushed
the
preview-store-omit-admin-url-in-store-info
branch
from
ffb7e3b to
468b1b6
Compare
amcaplan
force-pushed
the
preview-store-access-url-in-store-info
branch
from
309aaa6 to
8491e6d
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
shopify store infono longer surfaces an admin URL for preview stores.Why
The admin URL doesn't resolve for an unclaimed preview store, so showing it is misleading. Preview stores already get their info from the locally stored session plus the claim/access URLs (they short-circuit before
StoreInfoAdminShopQuery), sopartnerDevelopmentwas never queried for them and needs no change here.Changes
index.ts— dropadminUrlfrombuildPreviewStoreResult.index.test.ts— update the preview-store assertion and explicitly assertadminUrlis omitted.No changeset: preview stores aren't a public feature yet.
🤖 Generated with Claude Code