Skip to content

fix: Gracefully handle steam as underlay in overlay mode via launch options - #531

Open
KyleGospo wants to merge 5 commits into
ShadowBlip:mainfrom
KyleGospo:overlay-tdp-fix
Open

fix: Gracefully handle steam as underlay in overlay mode via launch options#531
KyleGospo wants to merge 5 commits into
ShadowBlip:mainfrom
KyleGospo:overlay-tdp-fix

Conversation

@KyleGospo

@KyleGospo KyleGospo commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Disables most TDP control when --steamos-manager is specified, this otherwise conflicts with SteamOS-Manager and causes TDP to always apply the OGUI options unless the Steam QAM is open

Additionally fixes a bug with user defined controllers being ignored, sets the default controller to steam deck in overlay mode, allows device configs to override that default if something like Xbox is required for their hardware, and disables per game controller configs when --steam-input is specified.

Comment thread core/systems/performance/performance_manager.gd Outdated
@KyleGospo KyleGospo changed the title fix: Disable TDP control when in overlay mode fix: Disable TDP control when Steam is the underlay Aug 27, 2026
@KyleGospo KyleGospo changed the title fix: Disable TDP control when Steam is the underlay fix: Gracefully handle steam as underlay in overlay mode Aug 27, 2026
@KyleGospo

Copy link
Copy Markdown
Contributor Author

Squashed into a single PR per @pastaq

Comment thread core/ui/card_ui_overlay_mode/card_ui_overlay_mode.gd Outdated
Comment thread core/systems/performance/performance_manager.gd Outdated
Comment thread core/ui/common/quick_bar/performance_menu.gd Outdated
Comment thread core/global/launch_manager.gd Outdated
Comment thread core/systems/input/input_manager.gd Outdated
Comment thread core/global/launch_manager.gd Outdated
…onflicts with SteamOS-Manager and causes TDP to always apply the OGUI options unless the Steam QAM is open
@pastaq

pastaq commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Before I merge this I want to get input from @GloriousEggroll as this will affect Nobara. AFAIK they are not using SteamOS Manager at this time. If thy aren't going to add OGC steamos-manager we might need to consider passing a new CLI arg in the session instead.

Comment thread core/global/launch_manager.gd
Comment thread core/global/launch_manager.gd
@pastaq

pastaq commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Looking again at patch 3, that won't work for some devices. Notably there are some devices that don't have a dedicated QAM button. The GPD Win 4 is a popular example. With the deck, deck-uhid, and horipad targets Steam doesn't respond to guide+a to open the QAM. This leaves those users with no way to open the Steam QAM.

We have a couple of options for a different approach. Option 1 is to led OpenGamepadUI respect the SteamOS Manager set target device if a profile target isn't set. This is close to the current behavior already, though we'd reintroduce the resume issue and would need to figure out a solution for that.

The other option would be to let an OpenGamepadUI platform specify a target to override the default target. This would require adding platforms for every affected device.

Comment thread core/ui/card_ui/gamepad/gamepad_settings.gd Outdated
Comment thread core/ui/card_ui/gamepad/gamepad_settings.gd
Comment thread core/ui/card_ui_overlay_mode/card_ui_overlay_mode.gd Outdated
@KyleGospo

Copy link
Copy Markdown
Contributor Author

I like the override by platform, and if needed for nobara the steam underlay stuff can become it's own launch option

@GloriousEggroll

Copy link
Copy Markdown

the steamdeck tdp only applies to the deck itself afaik -- why are we disabling ogui tdp control? in nobara we just disable the overlay for steam deck ie if steamdeck, launch without ogui, else launch with ogui.

literally the only time you need the ogui overlay is on non-steamdeck devices

@pastaq

pastaq commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

the steamdeck tdp only applies to the deck itself afaik -- why are we disabling ogui tdp control? in nobara we just disable the overlay for steam deck ie if steamdeck, launch without ogui, else launch with ogui.

Vanilla SteamOS Manager does TDP for Legion, MSI, and Asus devices as well.
OGC SteamOS Manager connects to Power Station for everything else. This enables the steam TDP and GPU Clock sliders in steam itself to function fully. OpenGamepadUI can then just provide extra options not controlled by Steam.

literally the only time you need the ogui overlay is on non-steamdeck devices

@KyleGospo
KyleGospo force-pushed the overlay-tdp-fix branch 3 times, most recently from d6dfaf3 to a0d81c8 Compare September 2, 2026 01:55
@KyleGospo

KyleGospo commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@pastaq As requested this is now split into two separate launch options
--steamos-manager gates the TDP changes, and --steam-input gates the controller profile changes minus the deck-uhid default change and default-controller-in-profile change, both of which are useful even in a full OGUI session.

@KyleGospo KyleGospo changed the title fix: Gracefully handle steam as underlay in overlay mode fix: Gracefully handle steam as underlay in overlay mode via launch options Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants