fix(chart): drain s3proxy pods on scale-in instead of killing in-flight uploads#136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The KEDA connection-demand trigger (argocd-system #807, live since 2026-07-19 ~14:30 UTC) fixed scale-in decisions — the fleet no longer reads idle while busy. But the 2026-07-19 backup run still died at 23:49 UTC with InvalidPart, because scale-in execution is still a hard kill:
InvalidParton CompleteMultipartUpload.Fix
Let a terminating pod finish what it's serving:
sleep 10— pod keeps accepting while it drops out of the headless-service DNS, so HAProxy (server-template + resolvers) stops routing new connections to it before uvicorn stops listening. Existing connections are untouched by HAProxy when a resolved server goes away.terminationGracePeriodSeconds: 600(was 30, now a values knob) — uvicorn on SIGTERM stops accepting and waits for in-flight requests, then exits immediately. The grace period only needs to cover the longest single request; 600s bounds a slow multi-minute part copy. Pods exit as soon as they're idle — the ceiling costs nothing in the common case.Chart-only change, no image change needed.