Merge master into vimf - #219
Merged
Merged
Conversation
* Lower required precision between cumsum and sum quantities Running on L200m6 crashed for half light radii (difference was 0.13% instead of less than 0.1%) * Implement helper function for mass-weighted rotational velocity * Define azimuthal velocity for subhalo apertures. * Add helper function for cylindrical velocity dispersion vector * Define cylindrical dispersion quantities for aperture properties * Add missing property declaration * Define luminosity-weighted kinematic properties Still need to think of how to handle different angular momentum vectors. * Change calculate_cylindrical_velocities to take reference pos and vel * Define cylindrical velocity calculation on a per-luminosity-band basis * Implementation of luminosity-weighted rotational velocity Testing pending. * Implement luminosity-weighted cylindrical dispersion routines. Tests to be done * Define luminosity weighted kinematics for aperture properties * Add new properties to parameter file * Add new properties to property table * Incorrect function call * Declare properties for bound subhalo * Fix indexing of arrays * Do not recentre star coordinates for cylindrical velocities We do not do so when computing the angular momentum vector, so this change makes it consistent with our choice to not re-centre. * Use stellar centre of mass as reference velocity Including the case for when we do luminosity-weighting. This reflects the same choice we made when computing luminosity-weighted angular momenta. * Use STELLAR CoM velocity as reference, not ALL CoM velocity. * Fix bug: accidental change of velocities within function * Run formatter * Update property table.
* Virtual v1 * Combine update_vds_path with make_virtual_snapshot * Virtual snapshot creation using multiple auxilary files * BirthHaloCatalogueIndex v1 * Identify gas progenitor * Add ExSitu fraction property to SOAP * Add sbatch script * Remove extra parameter file * Format * Learn to spell * Add to BoundSubhalo * Handle named columns * Format * Move compression dir * Format
* Add citation files * Update readme * Update readme * Add ads link
* Update EAGLE script for WDM run * Format
* Working? version * Add more options * Delete unused param file * Missing import * Set separate chunk thresholds * Update subfind radius
* Add rst generation * Move dropdown * Updates * Joop comments * Add links for citations * Output human units * Remove old footnote
* Change attribute reading * Update virgodc version
* Handle DM in mass table * Various fixes * Format
* Flush errors * Pass halo indices as a file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.