Remove unsupported parameter SkipTrackIDOffsets#908
Open
PetrilloAtWork wants to merge 1 commit into
Open
Conversation
The parameter `SkipTrackIDOffsets` is supported by `MergeSimSources` but not by `MergeSimSourcesSBN`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameter
SkipTrackIDOffsetsis supported byMergeSimSourcesbut not byMergeSimSourcesSBN.The C.I. tests should validate the change.
Historical note
From my investigation, many years ago Laura Domine needed a customisation of
MergeSimSourcesfor ICARUS Machine Learning simulation path, and frustrated by the impossibility to make a derived class she copied the module altogether (MergeSimSourcesSBN). The special ICARUS configuration that comes with it (largeantdropped) was derived from the one used for the "standard" workflow.Fast forward one year, a new desired feature is added in the original LArSim version, and ICARUS updates the standard configuration and the ML one (
largeantdropped) silently inherits the change (the dates are confusing... ICARUS configuration change seems to predate by a lot the change in LArSoft...). So: the code has diverged, the configuration has not,MergeSimSourcesSBNcan't handle the new parameter and it has it known. Why we notice now is probably a story of mixed branches, partial patches and the wish to go fast and furious.This patch
I am just removing the unsupported parameter from
largeantdroppedconfiguration, leaving it in theicarus_merge_sim_sources("standard") one. The two configurations are still related.