fix(DM01-6173): prevent shell injection and MCP transaction corruption - #634
Merged
Conversation
- job.py: use shlex.quote() on source/output args in compress/uncompress to prevent shell metacharacter injection; shell=True pipeline preserved - handler.go: replace bash -c string concat with exec.Command arg list in getOutdatedClusters to eliminate maxAge injection path - auth.py: call g.db.rollback() when last_used_at update fails to avoid leaving the connection in an aborted transaction state
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/job/job.py: Useshlex.quote()onsource/outputargs incompress()anduncompress()to prevent shell metacharacter injection. Preserves existingshell=Truepipeline structure andconsole.executelogging.src/services/gcp/pkg/stub/handler.go: Replaceexec.Command("bash", "-c", "gcloud ..."+maxAge)with a directexec.Command("gcloud", ...)argument list, eliminating themaxAgestring concatenation injection path.src/api/handlers/mcp/auth.py: Callg.db.rollback()when thelast_used_atupdate fails, preventing the DB connection from remaining in an aborted transaction state and causing the rest of the MCP request to fail.Test plan
compress()/uncompress()still works correctly with normal job input/output pathsgetOutdatedClustersgcloud filter produces identical results with the new argument list formpytest src/api/handlers/mcp/— all 35 tests pass including the two new regression tests for rollback behavior