WEB-PRIVACY-001A: redact public Shop catalog failures#255
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254
Outcome
The public
/shoproute now treats a rejected catalog read as untrusted. It discards the rejection and shows exactlyWe could not load the shop right now. Please try again later.in an assertive atomic alert.Loading ends on failure. Genuine empty catalogs and successful product displays remain unchanged.
Safety invariant
Verification
Old-source red proof:
messagegetter executed and prevented a safe resultFinal local proof on Node 20:
git diff --check: passedb86151e38c269d0b5f2b1f741a225abe95164e90d0d1eefb54751c10354d0eafScope
Only:
src/pages/shop/Shop.tsxsrc/App.test.jsxdocs/officers/EVENTS_SHOP_MEMBERS.mdOpen commerce #249/#246 paths are disjoint and untouched.
Officer impact: Visitors and officers receive one plain retry-later instruction without database, provider, account, endpoint, or technical detail.
Officer documentation:
docs/officers/EVENTS_SHOP_MEMBERS.md, sectionPublic Shop catalog failure privacy — SOURCE ONLY, NOT LIVE.Deployment evidence: None yet. This pull request changes source, tests, and documentation only. No release workflow, production website,
runmprc.com, Firebase, database permissions, provider configuration, production data, migration, or live-behavior action occurred.Residual risk
This source slice does not publish the website, deploy or verify Firebase, change catalog permissions, configure a provider, or prove live behavior. Those require a separately approved protected release and exact revision checks.