OAUTH-001A2B: redact Strava activity-load browser failures#251
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
My Account now treats a rejected Strava stats value as opaque and shows one fixed retry-later alert. It no longer reads or renders the rejection's
message, and successful activity display remains unchanged.Closes #250. Canonical parent #88 remains open.
Privacy and behavior invariant
We could not load your Strava activity right now. Please try again later.Proof
provider-private-canary member@example.testand had no fixed alert.messagegetter non-inspection, five-console silence, loading completion, connected identity, and successful projection.git diff --check: PASS.e773c132171e09b6318d5d94135befcf080e3610fa9d22b254876d9fd0d702c7.All Firebase and Strava behavior in tests is mocked. No provider or production network path ran.
Residual risk and migration
Migration impact: none. No stored data, schema, permission, or provider behavior changes.
Explicitly excluded and still unsafe: the existing browser disconnect catch can render a raw rejection message. It remains a separately claimable OAUTH-001B browser child. Connection-load recovery, server/provider response validation, callback/state/code/App Check, tokens/scopes/account binding, refresh concurrency, revoke/audit, IAM/encryption, provider setup, deployment, and live verification remain under #88.
Officer handoff
Officer impact: members receive one plain retry-later sentence instead of technical/provider detail. Keep it marked source-only until the exact website revision is published and verified.
Officer documentation:
docs/officers/EVENTS_SHOP_MEMBERS.md— added the separately namedStrava activity failure privacy — SOURCE ONLY, NOT LIVErecognition/evidence section.Deployment evidence: Source changed and local tests passed. Website publication: not performed.
runmprc.com: not verified because no website publication occurred. Firebase deployment: not performed. Strava/provider configuration: not changed or verified. Production data/migration: none. Live behavior: not claimed.