Skip to content

OAUTH-001B1: Redact Strava disconnect failure logs#237

Merged
daliu merged 1 commit into
mainfrom
codex/issue-235-strava-disconnect-redaction
Jul 14, 2026
Merged

OAUTH-001B1: Redact Strava disconnect failure logs#237
daliu merged 1 commit into
mainfrom
codex/issue-235-strava-disconnect-redaction

Conversation

@daliu

@daliu daliu commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Closes #235

Outcome

A failed Strava deauthorization transport call now emits only the fixed marker strava_disconnect_revoke_failed. Provider exception messages, URLs, tokens, bodies, causes, and details no longer reach this warning.

Preserved behavior and boundaries

  • App Check and authenticated-caller checks still run before Firestore, provider access, or deletion.
  • Disconnect still makes at most one best-effort provider POST.
  • Missing tokens skip provider access.
  • HTTP non-success responses remain ignored.
  • Both local delete attempts still run and delete failures remain swallowed.
  • The callable still returns { ok: true }.

This source-only child does not claim retry-safe revocation, confirmation of provider revocation, durable audit, successful local deletion, provider configuration, or completion of OAUTH-001B.

Verification

  • Red proof on the prior source: 27 focused Strava tests passed and exactly the fixed-warning transport test failed, exposing the old two-argument raw exception log.
  • Green focused Strava suite: 28/28 passed.
  • Shuffled focused suite (seed 23501): 28/28 passed.
  • Functions lint: passed.
  • Full Functions suite: 1,495 passed; 47 conditional/emulator skips.
  • git diff --check: passed.
  • Two independent exact-diff reviews: passed with no actionable findings.
  • Only functions/strava.js and functions/strava.test.js changed.

Officer impact: A Strava disconnect transport failure is less likely to place provider or token-bearing exception details in operational logs. Member-facing disconnect behavior is unchanged.

Officer documentation: None — this narrowly changes an internal failure log and tests; it does not change an officer procedure, permission, public page, or available operation.

Deployment evidence: Source and local tests only. No website publication, Firebase deployment, Strava/provider action, production-data action, or live behavior verification was performed.

@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for luminous-fox-7c393f ready!

Name Link
🔨 Latest commit f1f48b1
🔍 Latest deploy log https://app.netlify.com/projects/luminous-fox-7c393f/deploys/6a55d4a5fdcc430008d543b4
😎 Deploy Preview https://deploy-preview-237--luminous-fox-7c393f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daliu daliu force-pushed the codex/issue-235-strava-disconnect-redaction branch from 67083a0 to f1f48b1 Compare July 14, 2026 06:18
@daliu daliu merged commit 139c762 into main Jul 14, 2026
9 checks passed
@daliu daliu deleted the codex/issue-235-strava-disconnect-redaction branch July 14, 2026 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAUTH-001B1 — Redact Strava disconnect failure logs

1 participant