OAUTH-001B1: Redact Strava disconnect failure logs#237
Merged
Conversation
✅ Deploy Preview for luminous-fox-7c393f ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
67083a0 to
f1f48b1
Compare
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235
Outcome
A failed Strava deauthorization transport call now emits only the fixed marker
strava_disconnect_revoke_failed. Provider exception messages, URLs, tokens, bodies, causes, and details no longer reach this warning.Preserved behavior and boundaries
{ ok: true }.This source-only child does not claim retry-safe revocation, confirmation of provider revocation, durable audit, successful local deletion, provider configuration, or completion of OAUTH-001B.
Verification
git diff --check: passed.functions/strava.jsandfunctions/strava.test.jschanged.Officer impact: A Strava disconnect transport failure is less likely to place provider or token-bearing exception details in operational logs. Member-facing disconnect behavior is unchanged.
Officer documentation: None — this narrowly changes an internal failure log and tests; it does not change an officer procedure, permission, public page, or available operation.
Deployment evidence: Source and local tests only. No website publication, Firebase deployment, Strava/provider action, production-data action, or live behavior verification was performed.