Add support in vinca-pinning-render to completly delete pinning key from conda-forge-pinnings - #157
Open
traversaro wants to merge 1 commit into
Open
traversaro wants to merge 1 commit into
traversaro wants to merge 1 commit into
Conversation
…rom conda-forge-pinnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was something that I was experimenting with in my branch and in RoboStack/ros-rolling#43, but then the
<key>: nullsyntax was reused also in RoboStack/ros-rolling#41 . Without this change, setting for exampledocker_image: nullinvinca_pinning.yamldoes not completly remove thedocker_imagekey from the generatedconda_build_config.yaml, but it just leaves it do not set (see for examplechannel_sourcesandchannel_targetsin https://github.com/RoboStack/ros-rolling/blob/c1a2a6c57e227f5a0884ba05c278ecd1ef5c9647/conda_build_config.yaml#L146).With this PR, any key set to
nullis completely removed from the generated conda_build_config.yaml, to avoid any confusion.